feat: logs for remote access - #26
Open
aln730 wants to merge 17 commits into
Open
Conversation
Feat/dd metrics
costowell
reviewed
Aug 2, 2026
costowell
reviewed
Aug 2, 2026
costowell
reviewed
Aug 3, 2026
aln730
force-pushed
the
remote-access-logs
branch
5 times, most recently
from
August 6, 2026 02:36
0c58b48 to
929bcc7
Compare
costowell
previously approved these changes
Aug 6, 2026
costowell
left a comment
costowell
left a comment
Contributor
There was a problem hiding this comment.
Super minor comments now. Thank you for making all of those edits, this looks basically ready to merge!
|
|
||
| router.get("/provision", async (req, res) => { | ||
| const stem = { userId: req.ctx.userId, mobile: true }; | ||
| const stem = { userId: req.ctx.userId, type: "mobile" }; |
Contributor
There was a problem hiding this comment.
Does there need to be a migration run on the DB too?
Member
Author
There was a problem hiding this comment.
Yeah, the DB migration is needed. Right now mobile keys have mobile: true set, but physical keys just lack that field entirely rather than having mobile: false, so anything reading key type has to infer it from missing values instead of a stated value
Contributor
|
chom |
costowell
previously approved these changes
Aug 6, 2026
aln730
force-pushed
the
remote-access-logs
branch
2 times, most recently
from
August 6, 2026 23:28
2237db9 to
33d4a8e
Compare
aln730
force-pushed
the
remote-access-logs
branch
from
August 7, 2026 23:58
33d4a8e to
ab94458
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
title
Why
needs logs to keep eye on rtp powers
Test Plan
comment out:
in routes/doors.js
It is somewhat similar stuff to physical door acess logs
Discard the stuff below. I made a stacked PR that'll make testing easy cus doors are offline
In frontend. ahhh create a new branch without the head commitALSO why does vscode keep fucking up whitespaces OMG
Env Vars
N/A
Documentation
N/A
Checklist